fix(storage): prevent duplicate COS resource uploads
This commit is contained in:
1 parent
70d272853e
commit
72a7f85d56
13 files changed
+339
-64
No files matched your search
@@ -831,6 +831,59 @@ func newResourceTestService(t *testing.T) *Service {
|
||||
return &Service{repo: repository.New(db), dataDir: t.TempDir()}
|
||||
}
|
||||
|
||||
func TestStoreResourceReusesReadyUploadIdentity(t *testing.T) {
|
||||
svc := newResourceTestService(t)
|
||||
uploadKey := normalizedResourceUploadKey([]string{"image:user-1:logical-upload"})
|
||||
first, stored, err := svc.storeResource("user-1", "image", "first.png", "image/png", 7, 1, 1, 0, bytes.NewReader([]byte("payload")), uploadKey)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if !stored {
|
||||
t.Fatal("first upload was not stored")
|
||||
}
|
||||
second, stored, err := svc.storeResource("user-1", "image", "second.png", "image/png", 7, 1, 1, 0, bytes.NewReader([]byte("payload")), uploadKey)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if stored || second.ID != first.ID || second.ObjectKey != first.ObjectKey {
|
||||
t.Fatalf("idempotent upload = %#v, stored=%v; first=%#v", second, stored, first)
|
||||
}
|
||||
resources, err := svc.repo.Resources("user-1", 10)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(resources) != 1 {
|
||||
t.Fatalf("resource count = %d, want 1", len(resources))
|
||||
}
|
||||
}
|
||||
|
||||
func TestRetryStoredResourceKeepsOriginalObjectKey(t *testing.T) {
|
||||
svc := newResourceTestService(t)
|
||||
uploadKey := normalizedResourceUploadKey([]string{"image:user-1:retry-upload"})
|
||||
failed := &model.Resource{
|
||||
ID: "resource-failed", UserID: "user-1", Kind: "image", Status: model.ResourceStatusFailed,
|
||||
Provider: "local", ObjectKey: "users/user-1/image/fixed.png", MimeType: "image/png", Size: 7,
|
||||
UploadKey: uploadKey, CreatedAt: time.Now(), UpdatedAt: time.Now(),
|
||||
}
|
||||
if err := svc.repo.CreateResource(failed); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
retried, err := svc.retryStoredResource("user-1", failed, "image", "image/png", 7, bytes.NewReader([]byte("payload")))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if retried.ID != failed.ID || retried.ObjectKey != "users/user-1/image/fixed.png" || retried.Status != model.ResourceStatusReady {
|
||||
t.Fatalf("retried resource = %#v", retried)
|
||||
}
|
||||
resources, err := svc.repo.Resources("user-1", 10)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(resources) != 1 {
|
||||
t.Fatalf("resource count = %d, want 1", len(resources))
|
||||
}
|
||||
}
|
||||
|
||||
func TestLegacyMediaMigrationSkipsInvalidDataURL(t *testing.T) {
|
||||
svc := &Service{}
|
||||
input := map[string]interface{}{
|
||||
|
||||
Reference in new issue
Block a user