ttstd-infinite-canvas/backend/internal/app/cloud_agent_skill_feedback_test.go

package app

import (
	"encoding/json"
	"strings"
	"testing"

	"infinite-canvas/backend/internal/model"
)

func skillFeedbackCall(id, path string) cloudAgentCall {
	call := cloudAgentCall{ID: "call"}
	call.Function.Name = "skill_read_file"
	args, _ := json.Marshal(map[string]string{"skillId": id, "path": path})
	call.Function.Arguments = string(args)
	return call
}

func TestCloudAgentSkillEmptyDirectoryAndRepeatedRead(t *testing.T) {
	state := cloudAgentRuntime{Skills: []cloudAgentSkill{{ID: "script", Name: "剧本撰写", Instruction: "# 剧本撰写", Files: map[string]string{}}}}
	call := skillFeedbackCall("script", "")
	result, err := cloudAgentReadTool(nil, "user", &state, call)
	if err != nil {
		t.Fatal(err)
	}
	data := result.(map[string]any)
	if data["entryPath"] != cloudAgentSkillEntryPath || strings.Join(data["files"].([]string), ",") != cloudAgentSkillEntryPath || !strings.Contains(data["guidance"].(string), "先读取 SKILL.md") {
		t.Fatalf("missing empty-directory guidance: %+v", data)
	}
	cloudAgentToolResult("", &state, call, result, nil)
	if event := state.Events[0]; event.Type != "tool_completed" || event.Payload["skillName"] != "剧本撰写" || event.Payload["path"] != "" {
		t.Fatalf("missing tool context: %+v", event)
	}
	run := &model.CloudAgentExecution{}
	if err := cloudAgentSave(run, &state); err != nil {
		t.Fatal(err)
	}
	restored, err := cloudAgentDecode(run)
	if err != nil {
		t.Fatal(err)
	}
	if _, err := cloudAgentReadTool(nil, "user", &restored, call); err == nil || !strings.Contains(err.Error(), "不要重复读取") {
		t.Fatalf("repeated request after reload was not rejected: %v", err)
	}
}

func TestCloudAgentSkillEntryDocumentIsReadableFromSnapshot(t *testing.T) {
	state := cloudAgentRuntime{Skills: []cloudAgentSkill{{
		ID: "script", Version: "v1", Instruction: "# 剧本撰写\n\n只是一份任务剧本。",
		Files: map[string]string{cloudAgentSkillEntryPath: "stale duplicate", "references/format.md": "格式参考"},
	}}}
	paths := cloudAgentSkillPaths(state.Skills[0])
	if strings.Join(paths, ",") != "SKILL.md,references/format.md" {
		t.Fatalf("entry path was missing or duplicated: %v", paths)
	}
	result, err := cloudAgentReadTool(nil, "user", &state, skillFeedbackCall("script", cloudAgentSkillEntryPath))
	if err != nil {
		t.Fatal(err)
	}
	data := result.(map[string]any)
	if data["path"] != cloudAgentSkillEntryPath || data["content"] != state.Skills[0].Instruction {
		t.Fatalf("skill entry did not come from immutable instruction snapshot: %+v", data)
	}
}

func TestCloudAgentSkillMissingAndDistinctPaths(t *testing.T) {
	state := cloudAgentRuntime{Skills: []cloudAgentSkill{
		{ID: "script", Files: map[string]string{"references/b.md": "B", "references/a.md": "A"}},
		{ID: "other", Files: map[string]string{"references/a.md": "other"}},
	}}
	result, err := cloudAgentReadTool(nil, "user", &state, skillFeedbackCall("script", ""))
	if err != nil || strings.Join(result.(map[string]any)["files"].([]string), ",") != "references/a.md,references/b.md" {
		t.Fatalf("directory not sorted: %+v, %v", result, err)
	}
	for _, test := range []struct{ id, path, content string }{{"script", "references/a.md", "A"}, {"script", "references/b.md", "B"}, {"other", "references/a.md", "other"}} {
		result, err := cloudAgentReadTool(nil, "user", &state, skillFeedbackCall(test.id, test.path))
		if err != nil || result.(map[string]any)["content"] != test.content {
			t.Fatalf("distinct read rejected: %+v, %v", result, err)
		}
	}
	call := skillFeedbackCall("script", "references/missing.md")
	result, err = cloudAgentReadTool(nil, "user", &state, call)
	if err == nil || !strings.Contains(err.Error(), "references/a.md") {
		t.Fatalf("missing available paths: %v", err)
	}
	cloudAgentToolResult("run", &state, call, result, err)
	if state.Events[0].Type != "tool_failed" || state.Events[0].Payload["path"] != "references/missing.md" {
		t.Fatalf("missing failure context: %+v", state.Events[0])
	}
	if _, err := cloudAgentReadTool(nil, "user", &state, call); err == nil || !strings.Contains(err.Error(), "不要重复读取") {
		t.Fatalf("missing path was retried: %v", err)
	}
	if _, err := cloudAgentReadTool(nil, "user", &state, skillFeedbackCall("disabled", "")); err == nil {
		t.Fatal("unselected skill accepted")
	}
}

func TestCloudAgentModelFailureRedactsProviderDetails(t *testing.T) {
	for _, test := range []struct{ raw, reason string }{
		{"connection reset by peer", "model_connection_reset"},
		{"context deadline exceeded", "model_request_timeout"},
		{"connection refused", "model_connection_refused"},
		{"unknown provider error", "model_task_failed"},
	} {
		text, reason := cloudAgentModelFailure(&model.Task{ID: "task-id", Error: `Post "https://private.example?key=secret": ` + test.raw})
		if reason != test.reason || !strings.Contains(text, "task-id") || strings.Contains(text, "private") || strings.Contains(text, "secret") {
			t.Fatalf("unsafe or incorrect error: %q, %q", text, reason)
		}
	}
}

func TestCloudAgentFailedModelEmitsSafeReason(t *testing.T) {
	s, db, _, _ := creationTestService(t)
	if err := db.Create(&model.CanvasProject{ID: "agent-canvas", UserID: "user", PayloadJSON: `{"nodes":[]}`}).Error; err != nil {
		t.Fatal(err)
	}
	run, err := s.CreateCloudAgentRun("user", agentTestRequest(), "")
	if err != nil {
		t.Fatal(err)
	}
	if err := db.Model(&model.Task{}).Where("id = ?", run.ID).Updates(map[string]any{"status": model.TaskStatusFailed, "error": "private-url connection reset by peer"}).Error; err != nil {
		t.Fatal(err)
	}
	if err := s.advanceCloudAgentByID("user", run.ID); err != nil {
		t.Fatal(err)
	}
	stored, err := s.repo.CloudAgent("user", run.ID)
	if err != nil {
		t.Fatal(err)
	}
	state, err := cloudAgentDecode(stored)
	if err != nil {
		t.Fatal(err)
	}
	event := state.Events[len(state.Events)-1]
	if stored.Status != "failed" || event.Type != "run_failed" || event.Payload["reason"] != "model_connection_reset" || event.Payload["taskId"] != run.ID || strings.Contains(event.Payload["text"].(string), "private-url") {
		t.Fatalf("incorrect model failure event: %+v", event)
	}
}