From 9beb7d401559652d20f8319b5d0a7797b7e6d628 Mon Sep 17 00:00:00 2001
From: ray <1490493387@qq.com>
Date: Mon, 25 Nov 2024 23:28:36 +0800
Subject: [PATCH] =?UTF-8?q?refactor:=20:recycle:=20=E6=97=A5=E6=9C=9F?=
 =?UTF-8?q?=E8=8C=83=E5=9B=B4=E6=9F=A5=E8=AF=A2=E7=BB=84=E4=BB=B6=E5=B0=81?=
 =?UTF-8?q?=E8=A3=85=E9=81=BF=E5=85=8D=E6=97=A5=E6=9C=9F=E7=9A=84=E8=BD=AC?=
 =?UTF-8?q?=E6=8D=A2=EF=BC=8C=E7=94=A8=E6=88=B7=E5=92=8C=E6=97=A5=E5=BF=97?=
 =?UTF-8?q?=E6=A8=A1=E5=9D=97=E4=BC=98=E5=8C=96?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/api/system/log.ts                         |  24 +-
 src/api/system/user.ts                        |   2 +-
 src/components/cu-date-query/index.vue        |  69 ++++
 .../{CuPicker.vue => cu-picker/index.vue}     |   0
 src/pages/work/log/index.vue                  | 298 +++++++-----------
 src/pages/work/user/index.vue                 |  76 ++---
 src/utils/request.ts                          |  49 ---
 7 files changed, 214 insertions(+), 304 deletions(-)
 create mode 100644 src/components/cu-date-query/index.vue
 rename src/components/{CuPicker.vue => cu-picker/index.vue} (100%)

diff --git a/src/api/system/log.ts b/src/api/system/log.ts
index 2321b7b..926d2dd 100644
--- a/src/api/system/log.ts
+++ b/src/api/system/log.ts
@@ -2,19 +2,19 @@ import request from "@/utils/request";
 
 const LOG_BASE_URL = "/api/v1/logs";
 
-class LogAPI {
+const LogAPI = {
   /**
    * 获取日志分页列表
    *
    * @param queryParams 查询参数
    */
-  static getPage(queryParams: LogPageQuery) {
-    return request<PageResult<LogPageVO[]>>({
+  getPage(queryParams: LogPageQuery) {
+    return request<PageResult<LogVO[]>>({
       url: `${LOG_BASE_URL}/page`,
       method: "GET",
       data: queryParams,
     });
-  }
+  },
 
   /**
    * 获取访问趋势
@@ -22,13 +22,13 @@ class LogAPI {
    * @param queryParams
    * @returns
    */
-  static getVisitTrend(queryParams: VisitTrendQuery) {
+  getVisitTrend(queryParams: VisitTrendQuery) {
     return request<VisitTrendVO>({
       url: `${LOG_BASE_URL}/visit-trend`,
       method: "GET",
       data: queryParams,
     });
-  }
+  },
 
   /**
    * 获取访问趋势
@@ -36,13 +36,13 @@ class LogAPI {
    * @param queryParams
    * @returns
    */
-  static getVisitStats() {
+  getVisitStats() {
     return request<VisitStatsVO[]>({
       url: `${LOG_BASE_URL}/visit-stats`,
       method: "GET",
     });
-  }
-}
+  },
+};
 
 export default LogAPI;
 
@@ -51,15 +51,15 @@ export default LogAPI;
  */
 export interface LogPageQuery extends PageQuery {
   /** 搜索关键字 */
-  keywords: string;
+  keywords?: string;
   /** 操作时间 */
-  createTime: [string, string];
+  createTime?: [string, string] | string;
 }
 
 /**
  * 系统日志分页VO
  */
-export interface LogPageVO {
+export interface LogVO {
   /** 主键 */
   id?: number;
   /** 日志模块 */
diff --git a/src/api/system/user.ts b/src/api/system/user.ts
index f3d439c..4f21d7f 100644
--- a/src/api/system/user.ts
+++ b/src/api/system/user.ts
@@ -173,7 +173,7 @@ export interface UserPageQuery extends PageQuery {
   deptId?: number;
 
   /** 开始时间 */
-  createTime?: [string, string] | string | undefined;
+  createTime?: [string, string] | string;
 
   /** 排序字段 */
   field?: string;
diff --git a/src/components/cu-date-query/index.vue b/src/components/cu-date-query/index.vue
new file mode 100644
index 0000000..330d722
--- /dev/null
+++ b/src/components/cu-date-query/index.vue
@@ -0,0 +1,69 @@
+<template>
+  <wd-calendar
+    v-model="dateRange"
+    :label="label"
+    type="daterange"
+    :placeholder="placeholder"
+    @confirm="handleConfirm"
+  />
+</template>
+
+<script lang="ts" setup>
+import { dayjs } from "wot-design-uni";
+
+const props = defineProps({
+  modelValue: {
+    type: [Array, String] as PropType<[string, string] | string | undefined>,
+    default: () => undefined,
+  },
+  placeholder: {
+    type: String,
+    default: "请选择时间范围",
+  },
+  label: {
+    type: String,
+    default: "",
+  },
+});
+
+const emit = defineEmits(["update:modelValue"]);
+
+const dateRange = ref<number[] | number | null>(null);
+
+watch(
+  () => props.modelValue,
+  (val) => {
+    if (Array.isArray(val) && val.length === 2 && val[0] && val[1]) {
+      dateRange.value = val.map((item) => new Date(item).getTime());
+    } else {
+      dateRange.value = null;
+    }
+  },
+  {
+    immediate: true,
+  }
+);
+
+// 确认选择时间
+const handleConfirm = () => {
+  if (Array.isArray(dateRange.value) && dateRange.value.length === 2) {
+    const startDate = dayjs(dateRange.value[0]).format("YYYY-MM-DD");
+    const endDate = dayjs(dateRange.value[1]).format("YYYY-MM-DD");
+
+    let newVal: any = [startDate, endDate];
+
+    // #ifdef MP-WEIXIN
+    newVal = `${startDate},${endDate}`;
+    // #endif
+
+    console.log("newVal", newVal);
+    emit("update:modelValue", newVal);
+  }
+};
+</script>
+
+<style scoped>
+.time-filter {
+  padding: 16rpx;
+}
+</style>
diff --git a/src/components/CuPicker.vue b/src/components/cu-picker/index.vue
similarity index 100%
rename from src/components/CuPicker.vue
rename to src/components/cu-picker/index.vue
diff --git a/src/pages/work/log/index.vue b/src/pages/work/log/index.vue
index de5127e..e8a2463 100644
--- a/src/pages/work/log/index.vue
+++ b/src/pages/work/log/index.vue
@@ -1,8 +1,8 @@
 <template>
   <view class="log">
     <!-- 筛选 -->
-    <wd-drop-menu close-on-click-modal class="mb-20rpx">
-      <wd-drop-menu-item ref="dropMenu" title="筛选" icon="filter" icon-size="18px">
+    <wd-drop-menu close-on-click-modal class="mb-24rpx">
+      <wd-drop-menu-item ref="filterDropMenu" title="筛选" icon="filter" icon-size="18px">
         <view>
           <wd-input
             v-model="queryParams.keywords"
@@ -10,242 +10,148 @@
             type="text"
             placeholder="请输入关键字"
           />
-          <wd-calendar
-            v-model="timeStampArray"
-            label="日期选择"
-            type="daterange"
-            allow-same-day
-            @confirm="handleConfirm"
-          />
-          <view class="flex-between mb-20rpx">
-            <wd-button class="mt-20rpx mb-20rpx" size="medium" @click="handleSearch">
-              查询
-            </wd-button>
-            <wd-button size="medium" type="info" @click="handleReset">重置</wd-button>
+
+          <cu-date-query v-model="queryParams.createTime" :label="'日期选择'" />
+
+          <view class="flex-between py-2">
+            <wd-button class="w-20%" type="info" @click="handleResetQuery">重置</wd-button>
+            <wd-button class="w-70%" @click="handleQuery">查询</wd-button>
           </view>
         </view>
       </wd-drop-menu-item>
     </wd-drop-menu>
 
     <!-- 卡片列表 -->
-    <view v-for="(item, index) in pageData" :key="index">
-      <wd-card :title="item.operator">
-        <wd-row>
-          <wd-col v-for="(rowItem, rowIndex) in listPageTypeArray" :key="rowIndex" :span="12">
-            <wd-col :span="rowItem.titleSpan">
-              <view>{{ rowItem.title }}：</view>
-            </wd-col>
-            <wd-col :span="rowItem.keySpan">
-              <view>{{ item[rowItem.key] }}</view>
-            </wd-col>
-          </wd-col>
-        </wd-row>
-        <template #footer>
-          <wd-button size="small" plain @click="getDetail(item)">查看详情</wd-button>
-        </template>
-      </wd-card>
-    </view>
+    <wd-card v-for="(item, index) in pageData" class="card-list">
+      <template #title>
+        {{ item.operator }}
+      </template>
 
-    <!-- 查看详情 -->
-    <wd-action-sheet v-model="detailShow">
-      <view class="p-50rpx">
-        <wd-row v-for="(rowItem, rowIndex) in detailTypeArray" :key="rowIndex" class="mt-20rpx">
-          <wd-col :span="rowItem.titleSpan">
-            <view>{{ rowItem.title }}：</view>
-          </wd-col>
-          <wd-col :span="rowItem.keySpan">
-            <view>{{ logDetail[rowItem.key] }}</view>
-          </wd-col>
-        </wd-row>
-      </view>
-    </wd-action-sheet>
+      <wd-cell-group>
+        <wd-cell title="模块" :value="item.module" />
+        <wd-cell title="内容" :value="item.content" />
+        <wd-cell title="IP" :value="item.ip" />
+        <wd-cell title="地区" :value="item.region" />
+      </wd-cell-group>
+
+      <template #footer>
+        <view class="flex-between">
+          <view class="text-left">
+            <wd-text text="创建时间：" size="small" class="font-bold" />
+            <wd-text :text="item.createTime" size="small" />
+          </view>
+          <view class="text-right">
+            <wd-button type="primary" size="small" plain @click="handleViewDetail(item)">
+              查看详情
+            </wd-button>
+          </view>
+        </view>
+      </template>
+    </wd-card>
+
+    <!-- 详情弹窗 -->
+    <wd-popup v-model="detailDialogVisible" position="bottom">
+      <wd-cell-group>
+        <wd-cell title="操作人" :value="logDetail.operator" />
+        <wd-cell title="操作时间" :value="logDetail.createTime" />
+        <wd-cell title="模块" :value="logDetail.module" />
+        <wd-cell title="内容" :value="logDetail.content" />
+        <wd-cell title="IP" :value="logDetail.ip" />
+        <wd-cell title="地区" :value="logDetail.region" />
+        <wd-cell title="浏览器" :value="logDetail.region" />
+        <wd-cell title="终端系统" :value="logDetail.os" />
+        <wd-cell title="耗时(毫秒)" :value="logDetail.executionTime" />
+      </wd-cell-group>
+    </wd-popup>
 
     <!-- 加载更多 -->
-    <wd-loadmore custom-class="loadmore" :state="loadMoreState" />
+    <wd-loadmore v-if="total > 0" :state="loadMoreState" @reload="loadmore" />
+    <wd-status-tip v-else-if="total == 0" image="search" tip="当前搜索无结果" />
   </view>
 </template>
 <script lang="ts" setup>
-import LogAPI, { LogPageVO, LogPageQuery } from "@/api/system/log";
 import { LoadMoreState } from "wot-design-uni/components/wd-loadmore/types";
 import { DropMenuItemExpose } from "wot-design-uni/components/wd-drop-menu-item/types";
-import { dayjs } from "wot-design-uni";
 
+import LogAPI, { LogVO, LogPageQuery } from "@/api/system/log";
+import CuDateQuery from "@/components/cu-date-query/index.vue";
+
+const filterDropMenu = ref<DropMenuItemExpose>();
 const loadMoreState = ref<LoadMoreState>("loading");
 
 const queryParams = reactive<LogPageQuery>({
   pageNum: 1,
   pageSize: 10,
-  keywords: "",
-  createTime: ["", ""],
 });
 
-const timeStampArray = ref<number[]>([]);
+const total = ref(0);
+const pageData = ref<LogVO[]>([]);
+
+const logDetail = ref<LogVO>({});
+const detailDialogVisible = ref(false);
 
-/**
- * 日期格式化
- */
-function handleConfirm({ value }: Ref<number[]>) {
-  queryParams.createTime[0] = dayjs(value[0]).format("YYYY-MM-DD");
-  queryParams.createTime[1] = dayjs(value[1]).format("YYYY-MM-DD");
-}
 /**
  * 搜索栏
  */
-const dropMenu = ref<DropMenuItemExpose>();
-function handleSearch() {
-  pageData.value = [];
-  dropMenu.value?.close();
-  handleQuery();
-}
-
-/**
- * 重置搜索条件
- */
-function handleReset() {
-  queryParams.pageNum = 1;
-  queryParams.keywords = "";
-  queryParams.createTime = ["", ""];
-  timeStampArray.value = [];
-  pageData.value = [];
-  dropMenu.value?.close();
-  handleQuery();
-}
-
-// 日志卡片列表数据
-const pageData = ref<LogPageVO[]>([]);
-
-onLoad(() => {
-  handleQuery();
-});
-
-/**
- * 查询
- */
 function handleQuery() {
+  filterDropMenu.value?.close();
+  queryParams.pageNum = 1;
+  loadmore();
+}
+
+/**
+ * 重置搜索
+ */
+function handleResetQuery() {
+  queryParams.keywords = undefined;
+  queryParams.createTime = undefined;
+  handleQuery();
+}
+
+/**
+ * 加载更多
+ */
+function loadmore() {
   loadMoreState.value = "loading";
   LogAPI.getPage(queryParams)
     .then((data) => {
-      pageData.value?.push(...data.list);
+      pageData.value = data.list;
+      total.value = data.total;
+      queryParams.pageNum++;
     })
     .catch((e) => {
-      console.log("系统异常", e);
+      pageData.value = [];
     })
     .finally(() => {
       loadMoreState.value = "finished";
     });
 }
 
+/**
+ * 查看详情
+ */
+function handleViewDetail(item: LogVO) {
+  detailDialogVisible.value = true;
+  logDetail.value = item;
+}
+
 /**
  * 触底事件
  */
 onReachBottom(() => {
-  queryParams.pageNum++;
-  handleQuery();
+  if (queryParams.pageNum * queryParams.pageSize < total.value) {
+    loadmore();
+  } else if (queryParams.pageNum * queryParams.pageSize >= total.value) {
+    loadMoreState.value = "finished";
+  }
 });
 
-/**
- * 卡片列表展示字段
- */
-interface listPageType {
-  title: string;
-  key: keyof LogPageVO;
-  titleSpan: Number;
-  keySpan: Number;
-}
-const listPageTypeArray = ref<listPageType[]>([
-  {
-    title: "模块",
-    key: "module",
-    titleSpan: 8,
-    keySpan: 16,
-  },
-  {
-    title: "内容",
-    key: "content",
-    titleSpan: 8,
-    keySpan: 16,
-  },
-  {
-    title: "时间",
-    key: "createTime",
-    titleSpan: 8,
-    keySpan: 16,
-  },
-  {
-    title: "地区",
-    key: "region",
-    titleSpan: 8,
-    keySpan: 16,
-  },
-]);
-
-/**
- * 卡片内容详情
- */
-const logDetail = ref<LogPageVO>({});
-const detailShow = ref<boolean>(false);
-const detailTypeArray = ref<listPageType[]>([
-  {
-    title: "模块",
-    key: "module",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "内容",
-    key: "content",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "时间",
-    key: "createTime",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "地区",
-    key: "region",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "IP",
-    key: "ip",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "浏览器",
-    key: "browser",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "终端系统",
-    key: "os",
-    titleSpan: 6,
-    keySpan: 18,
-  },
-  {
-    title: "执行时间(ms)",
-    key: "executionTime",
-    titleSpan: 8,
-    keySpan: 16,
-  },
-]);
-
-function getDetail(item: LogPageVO) {
-  detailShow.value = true;
-  logDetail.value = item;
-}
+onLoad(() => {
+  handleQuery();
+});
 </script>
 
 <style lang="scss" scoped>
-.log {
-  background: #f8f8f8;
-}
-
 .wd-col {
   margin-top: 10rpx;
 }
@@ -255,4 +161,14 @@ function getDetail(item: LogPageVO) {
   justify-content: flex-end;
   padding: 0 50rpx;
 }
+
+.card-list {
+  :deep(.wd-cell__wrapper) {
+    padding: 4rpx 0;
+  }
+  :deep(.wd-cell) {
+    padding-right: 10rpx;
+    background: #f8f8f8;
+  }
+}
 </style>
diff --git a/src/pages/work/user/index.vue b/src/pages/work/user/index.vue
index 0cdb08e..87c0ebf 100644
--- a/src/pages/work/user/index.vue
+++ b/src/pages/work/user/index.vue
@@ -23,11 +23,11 @@
               placeholder="用户名/昵称/手机号"
             />
 
-            <wd-calendar v-model="createTimeRange" label="创建时间" type="daterange" />
+            <cu-date-query v-model="queryParams.createTime" label="创建时间" />
 
             <view class="flex-between py-2">
               <wd-button class="w-20%" type="info" @click="hendleResetQuery">重置</wd-button>
-              <wd-button class="w-70%" @click="handleQuery">确定</wd-button>
+              <wd-button class="w-70%" @click="handleQuery">查询</wd-button>
             </view>
           </view>
         </wd-drop-menu-item>
@@ -35,7 +35,7 @@
     </view>
 
     <!-- 用户卡片 -->
-    <wd-card v-for="item in dataList">
+    <wd-card v-for="item in pageData">
       <template #title>
         <view class="flex-between">
           <view class="flex-center">
@@ -82,7 +82,7 @@
       </template>
     </wd-card>
 
-    <wd-loadmore v-if="total > 0" :state="state" @reload="loadmore" />
+    <wd-loadmore v-if="total > 0" :state="loadMoreState" @reload="loadmore" />
     <wd-status-tip v-else-if="total == 0" image="search" tip="当前搜索无结果" />
     <wd-message-box />
 
@@ -128,19 +128,19 @@
 <script lang="ts" setup>
 import { LoadMoreState } from "wot-design-uni/components/wd-loadmore/types";
 import { FormRules } from "wot-design-uni/components/wd-form/types";
-import { useMessage, dayjs } from "wot-design-uni";
+import { useMessage } from "wot-design-uni";
 
 import UserAPI, { type UserPageQuery, UserPageVO, UserForm } from "@/api/system/user";
 import RoleAPI from "@/api/system/role";
 import DeptAPI from "@/api/system/dept";
 
-import CuPicker from "@/components/CuPicker.vue";
+import CuPicker from "@/components/cu-picker/index.vue";
+import CuDateQuery from "@/components/cu-date-query/index.vue";
 
 const message = useMessage();
-
-const loading = ref(false);
-const state = ref<LoadMoreState>("loading");
-const dataList = ref<UserPageVO[]>([]);
+const loadMoreState = ref<LoadMoreState>("loading");
+const filterDropMenu = ref();
+const userFormRef = ref();
 
 const sortValue = ref(0);
 const sortOptions = ref<Record<string, any>[]>([
@@ -154,11 +154,9 @@ const queryParams: UserPageQuery = {
   pageSize: 10,
 };
 
-const createTimeRange = ref<any[]>([null, null]);
-
-const filterDropMenu = ref();
-
 const total = ref(0);
+const pageData = ref<UserPageVO[]>([]);
+
 const dialog = reactive({
   visible: false,
 });
@@ -176,10 +174,8 @@ const initialFormData: UserForm = {
 
 const formData = reactive<UserForm>({ ...initialFormData });
 
-const userFormRef = ref();
 const roleOptions = ref<Record<string, any>[]>([]);
 const deptOptions = ref<OptionType[]>([]);
-
 const rules: FormRules = {
   username: [{ required: true, message: "请输入用户名" }],
   nickname: [{ required: true, message: "请输入昵称" }],
@@ -243,21 +239,6 @@ const handleSortChange = ({ value }: { value: number }) => {
 const handleQuery = () => {
   filterDropMenu.value?.close();
   queryParams.pageNum = 1;
-
-  // 格式化时间范围
-  const startDate = createTimeRange.value[0]
-    ? dayjs(createTimeRange.value[0]).format("YYYY-MM-DD")
-    : "";
-  const endDate = createTimeRange.value[1]
-    ? dayjs(createTimeRange.value[1]).format("YYYY-MM-DD")
-    : "";
-
-  queryParams.createTime = [startDate, endDate];
-
-  // #ifdef MP-WEIXIN
-  queryParams.createTime = `${startDate},${endDate}`;
-  // #endif
-
   loadmore();
 };
 
@@ -265,27 +246,27 @@ const handleQuery = () => {
  * 重置查询
  */
 const hendleResetQuery = () => {
-  filterDropMenu.value?.close();
-  queryParams.pageNum = 1;
-  queryParams.keywords = "";
-  queryParams.createTime = "";
-  createTimeRange.value = ["", ""];
-  loadmore();
+  queryParams.keywords = undefined;
+  queryParams.createTime = undefined;
+  handleQuery();
 };
 
 /**
  * 加载更多
  */
 function loadmore() {
-  state.value = "loading";
+  loadMoreState.value = "loading";
   UserAPI.getPage(queryParams)
     .then((data) => {
-      dataList.value = data.list;
+      pageData.value = data.list;
       total.value = data.total;
       queryParams.pageNum++;
     })
+    .catch((e) => {
+      pageData.value = [];
+    })
     .finally(() => {
-      state.value = "finished";
+      loadMoreState.value = "finished";
     });
 }
 
@@ -293,20 +274,13 @@ function loadmore() {
  * 打开弹窗
  */
 async function handleOpenDialog(id?: number) {
-  loading.value = true;
   dialog.visible = true;
   roleOptions.value = await RoleAPI.getOptions();
   deptOptions.value = await DeptAPI.getOptions();
   if (id) {
-    UserAPI.getFormData(id)
-      .then((data) => {
-        Object.assign(formData, { ...data });
-      })
-      .finally(() => {
-        loading.value = false;
-      });
-  } else {
-    loading.value = false;
+    UserAPI.getFormData(id).then((data) => {
+      Object.assign(formData, { ...data });
+    });
   }
 }
 
@@ -378,7 +352,7 @@ onReachBottom(() => {
   if (queryParams.pageNum * queryParams.pageSize < total.value) {
     loadmore();
   } else if (queryParams.pageNum * queryParams.pageSize >= total.value) {
-    state.value = "finished";
+    loadMoreState.value = "finished";
   }
 });
 
diff --git a/src/utils/request.ts b/src/utils/request.ts
index c610030..5909a49 100644
--- a/src/utils/request.ts
+++ b/src/utils/request.ts
@@ -16,7 +16,6 @@ export default function request<T>(options: UniApp.RequestOptions): Promise<T> {
         ...options.header,
         Authorization: getToken() ? `Bearer ${getToken()}` : "",
       },
-      data: handleData(options.data, options.method || "GET"),
       success: (response) => {
         console.log("success response", response);
         const resData = response.data as ResponseData<T>;
@@ -60,51 +59,3 @@ export default function request<T>(options: UniApp.RequestOptions): Promise<T> {
     });
   });
 }
-
-/**
- * 处理请求数据
- * @param data 请求数据
- * @returns 处理后的数据
- */
-function handleData(data: any, method: string) {
-  // 非微信小程序，且非GET请求，则不处理数据
-  const appInfo = uni.getAppBaseInfo();
-  if (method !== "GET" && appInfo.hostName !== "WeChat") {
-    return data;
-  }
-  if (!data) return data;
-
-  // 如果是对象，遍历处理每个属性
-  if (typeof data === "object") {
-    const result: Record<string, any> = {};
-    for (const key in data) {
-      const value = data[key];
-      if (Array.isArray(value)) {
-        let res = handleArray(value);
-        if (res) {
-          result[key] = res;
-        }
-      } else {
-        result[key] = value;
-      }
-    }
-    return result;
-  }
-
-  return data;
-}
-
-/**
- * 处理数组
- * @param value 数组
- * @returns 逗号分隔字符串
- */
-function handleArray(value: any[]) {
-  let str = "";
-  for (const item of value) {
-    if (item != 0 && item) {
-      str += `${item},`;
-    }
-  }
-  return str;
-}